Support executing the test host with a specific --fx-version and define a default#205
Merged
ViktorHofer merged 1 commit intomainfrom Feb 6, 2025
Merged
Support executing the test host with a specific --fx-version and define a default#205ViktorHofer merged 1 commit intomainfrom
ViktorHofer merged 1 commit intomainfrom
Conversation
…ne a default Allow executing the test host with a specific shared framework version (i.e. 10.0.0-ci). This is necessary as i.e. in the VMR, the live built shared framework has a `-dev` or `-ci` suffix which could be determined as "lower" than the toolset SDK's shared framework that the repo builds with. As an example `10.0.0-ci` and `10.0.0-dev` are considered lower than `10.0.0-preview.1` by the host (in accordance with semver2).
akoeplinger
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow executing the test host with a specific shared framework version (i.e. 10.0.0-ci). This is necessary as i.e. in the VMR, the live built shared framework has a
-devor-cisuffix which could be determined as "lower" than the toolset SDK's shared framework that the repo builds with. As an example10.0.0-ciand10.0.0-devare considered lower than10.0.0-preview.1by the host (in accordance with semver2).Unblocks dotnet/sdk#46558 (requires one update)